MNT: migrate tox configuration from tox.ini to tox.toml#19337
MNT: migrate tox configuration from tox.ini to tox.toml#19337neutrinoceros wants to merge 4 commits intoastropy:mainfrom
tox.ini to tox.toml#19337Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
b5bfaba to
d431bf4
Compare
|
I'm personally not super keen on this (yet) - the reason is that if we do this we really should do it across all astropy packages for consistency, and there's something to be said for being familiar with a format. The |
definitely.
both are really hard to me. At least TOML is a well established format that is used elsewhere, so I'm still seeing a gain here:
Though in my opinion the bulk of the benefit comes from trying to migrate now, so we get a chance to report problems upstream before the dust has settled and we're stuck between an unsupported format and something that doesn't work for us. |
|
Ok sounds good - I have no objections with having this open as an experiment (I've put the relevant label) to see if it's possible to get it working and what the final thing would look like, but I think we'll need to have a broader conversation if we want to go from experiment to actually merging this. |
pllim
left a comment
There was a problem hiding this comment.
I am blocking merge based on convo above. Thanks, all.
Description
would close #19334
opening now mostly so I don't loose this branch, but it's not working yet (see linked PRs and issues)