Skip to content

units: add neperian logarithm to logarithmic units#19319

Open
Alexsaphir wants to merge 1 commit intoastropy:mainfrom
Alexsaphir:feat/add-neperian-log-unit
Open

units: add neperian logarithm to logarithmic units#19319
Alexsaphir wants to merge 1 commit intoastropy:mainfrom
Alexsaphir:feat/add-neperian-log-unit

Conversation

@Alexsaphir
Copy link
Copy Markdown

Description

Add the ability to use Neperian log as units.

  • Added: LnUnit(LogUnit) and Ln(LogQuantity) and ln for the unit.
  • Use the existing LogUnit, by providing the correct from_physical and to_physical.
  • Extended the parser to support Unit('ln(m)')

Due to the insertions of the entries in the doc generated, I modified the values inside test_docgen.

I tried to extend the tests by adding a minimal testing class. I used the existing tests when possible.

This pull request is to address ...

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions github-actions bot added the units label Feb 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim added this to the v8.0.0 milestone Feb 23, 2026
@pllim
Copy link
Copy Markdown
Member

pllim commented Feb 24, 2026

Hello and thanks for your contribution! This is very interesting but can you please clarify on what science cases that have motivated you to implement this? Astronomers use log base 10 for the magnitude systems. Also, now that you have introduced a different base for the log, should astropy.units be able to translate between the bases (I cannot tell from the new tests you added)?

@pllim
Copy link
Copy Markdown
Member

pllim commented Feb 24, 2026

If we decide to proceed, this PR would also need:

  • change log
  • user facing doc, plus example
  • what's new entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants