units: add neperian logarithm to logarithmic units#19319
Open
Alexsaphir wants to merge 1 commit intoastropy:mainfrom
Open
units: add neperian logarithm to logarithmic units#19319Alexsaphir wants to merge 1 commit intoastropy:mainfrom
Alexsaphir wants to merge 1 commit intoastropy:mainfrom
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Member
|
Hello and thanks for your contribution! This is very interesting but can you please clarify on what science cases that have motivated you to implement this? Astronomers use log base 10 for the magnitude systems. Also, now that you have introduced a different base for the log, should |
Member
|
If we decide to proceed, this PR would also need:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to use Neperian log as units.
LnUnit(LogUnit)andLn(LogQuantity)andlnfor the unit.from_physicalandto_physical.Unit('ln(m)')Due to the insertions of the entries in the doc generated, I modified the values inside test_docgen.
I tried to extend the tests by adding a minimal testing class. I used the existing tests when possible.
This pull request is to address ...