Skip to content

follow up to #19315: avoid assert statements in business logic#19318

Open
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
neutrinoceros:bug/avoid-prod-assert
Open

follow up to #19315: avoid assert statements in business logic#19318
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
neutrinoceros:bug/avoid-prod-assert

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

Description

In response to @pllim's post-mortem review

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v7.2.1 milestone Feb 23, 2026
@neutrinoceros neutrinoceros added Bug backport-v7.2.x on-merge: backport to v7.2.x Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed labels Feb 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros neutrinoceros marked this pull request as ready for review February 24, 2026 21:44
@neutrinoceros neutrinoceros requested a review from a team as a code owner February 24, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release backport-v7.2.x on-merge: backport to v7.2.x Bug modeling no-changelog-entry-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant