Add substitutions to credits.rst for astropy.org site by Cadair · Pull Request #19192 · astropy/astropy

Cadair · 2026-01-20T17:32:05Z

Description

In rewriting astropy.org to use sphinx I need this to fix some errors.

By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

github-actions · 2026-01-20T17:32:16Z

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

Do the proposed changes actually accomplish desired goals?
Do the proposed changes follow the Astropy coding guidelines?
Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

pllim · 2026-01-20T17:59:44Z

docs/credits.rst


 For how to acknowledge Astropy, please see `the Acknowledging or Citing Astropy page <https://www.astropy.org/acknowledging.html>`_.
+
+.. These substitutions are duplicated here so this rst file can be used in the astropy.org site without triggering warnings.


But is this directive actually used in the doc build of this repo somewhere?

Yes they are in conf.py but the website can't read that.

Then do we have to delete this? Now we have duplicate here

astropy/docs/conf.py

Lines 533 to 535 in cb7e56a

# Astropy

"Astropy mailing list": "https://mail.python.org/mailman/listinfo/astropy",

"astropy-dev mailing list": "https://groups.google.com/group/astropy-dev",

No they might be used in other places in the docs

Then should we add extra comment to remind ourselves to keep in sync with conf.py?

docs/credits.rst

pllim · 2026-01-20T18:00:26Z

Does this need backport?

Cadair · 2026-01-20T18:00:47Z

Does this need backport?

No

pllim · 2026-01-20T18:05:05Z

p.s. Rebase to get green RTD pls

docs/credits.rst

pllim

Good luck!

* Add substitutions to credits.rst for astropy.org site

github-actions bot added the Docs label Jan 20, 2026

pllim reviewed Jan 20, 2026

View reviewed changes

docs/credits.rst Show resolved Hide resolved

pllim added this to the v8.0.0 milestone Jan 20, 2026

pllim added the no-changelog-entry-needed label Jan 20, 2026

Add substitutions to credits.rst for astropy.org site

858c5ea

Cadair force-pushed the credits-subs branch from 8241e38 to 858c5ea Compare January 20, 2026 18:47

Cadair commented Jan 20, 2026

View reviewed changes

docs/credits.rst Outdated Show resolved Hide resolved

Update docs/credits.rst

6a3793c

pllim approved these changes Jan 20, 2026

View reviewed changes

pllim enabled auto-merge (squash) January 20, 2026 19:02

pllim merged commit 96a77c5 into astropy:main Jan 20, 2026
33 of 34 checks passed

Cadair deleted the credits-subs branch January 20, 2026 20:40

Perikliscode pushed a commit to Perikliscode/astropy_PeriklisFork that referenced this pull request Jan 21, 2026

Add substitutions to credits.rst for astropy.org site (astropy#19192)

8dba5b9

* Add substitutions to credits.rst for astropy.org site


		For how to acknowledge Astropy, please see `the Acknowledging or Citing Astropy page <https://www.astropy.org/acknowledging.html>`_.

		.. These substitutions are duplicated here so this rst file can be used in the astropy.org site without triggering warnings.

	# Astropy
	"Astropy mailing list": "https://mail.python.org/mailman/listinfo/astropy",
	"astropy-dev mailing list": "https://groups.google.com/group/astropy-dev",

Uh oh!

Conversation

Cadair commented Jan 20, 2026

Description

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

pllim Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Cadair Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

pllim Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Cadair Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

pllim Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pllim commented Jan 20, 2026

Uh oh!

Cadair commented Jan 20, 2026

Uh oh!

pllim commented Jan 20, 2026

Uh oh!

Uh oh!

pllim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants