Skip to content

otto: forward astro telemetry-disabled state to Otto #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlaneve wants to merge 2 commits into
base: main
Choose a base branch
from
Open

otto: forward astro telemetry-disabled state to Otto #2130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3a70e9
otto: forward astro telemetry-disabled state to Otto
jlaneve May 8, 2026
5a0f9d9
test(otto): initialize viper in AfSuite to fix BuildEnv panic
jlaneve May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/otto/af_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"github.com/stretchr/testify/suite"

"github.com/astronomer/astro-cli/config"
testUtil "github.com/astronomer/astro-cli/pkg/testing"
)

type AfSuite struct {
Expand All @@ -22,6 +23,10 @@ type AfSuite struct {
func (s *AfSuite) SetupTest() {
s.origHomeConfigPath = config.HomeConfigPath
s.tmpDir = s.T().TempDir()
// Initialize viper before overriding HomeConfigPath — BuildEnv now calls
// telemetry.IsEnabled(), which reads config.CFG.TelemetryEnabled and panics
// if viper hasn't been initialized.
testUtil.InitTestConfig(config.CloudPlatform)
config.HomeConfigPath = s.tmpDir
}

Expand Down
9 changes: 9 additions & 0 deletions pkg/otto/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (

"github.com/astronomer/astro-cli/airflow/proxy"
"github.com/astronomer/astro-cli/config"
"github.com/astronomer/astro-cli/internal/telemetry"
)

// Config holds the environment configuration for spawning Otto.
Expand Down Expand Up @@ -116,6 +117,14 @@ func (c *Config) BuildEnv() []string {
set("ASTRO_DOMAIN", c.Domain)
set("ASTRO_ORGANIZATION", c.Organization)

// Forward the astro CLI's telemetry-disabled state. Users who ran
// `astro telemetry disable` (or set ASTRO_TELEMETRY_DISABLED=1) expect that
// to cover anything launched via `astro otto` too. Otto has its own
// OTTO_TELEMETRY_DISABLE env var as the kill switch; we just flip it on.
if !telemetry.IsEnabled() {
set("OTTO_TELEMETRY_DISABLE", "1")
}

// Stop `astro dev start` from popping a browser when Otto runs it.
// The user is already having a conversation in the TUI — surprise browser
// tabs steal focus and break the flow. Any `astro dev start` invoked by
Expand Down
30 changes: 30 additions & 0 deletions pkg/otto/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,36 @@ func (s *ConfigSuite) TestBuildEnv_SkipsEmptyValues() {
s.Equal(os.DevNull, afConfig)
}

func (s *ConfigSuite) TestBuildEnv_ForwardsTelemetryDisabledFromEnv() {
// User exported ASTRO_TELEMETRY_DISABLED=1 — that should propagate to Otto
// via OTTO_TELEMETRY_DISABLE so the agent stops sending traces too.
os.Setenv("ASTRO_TELEMETRY_DISABLED", "1")
defer os.Unsetenv("ASTRO_TELEMETRY_DISABLED")

env := (&Config{Token: "t"}).BuildEnv()

for _, e := range env {
if strings.HasPrefix(e, "OTTO_TELEMETRY_DISABLE=") {
s.Equal("OTTO_TELEMETRY_DISABLE=1", e)
return
}
}
s.Fail("OTTO_TELEMETRY_DISABLE should be set when astro telemetry is disabled")
}

func (s *ConfigSuite) TestBuildEnv_DoesNotSetTelemetryDisableWhenEnabled() {
// Default test config has telemetry enabled and the env var unset, so Otto
// should NOT see OTTO_TELEMETRY_DISABLE — leaving its default (send) intact.
os.Unsetenv("ASTRO_TELEMETRY_DISABLED")

env := (&Config{Token: "t"}).BuildEnv()

for _, e := range env {
s.False(strings.HasPrefix(e, "OTTO_TELEMETRY_DISABLE="),
"OTTO_TELEMETRY_DISABLE must not be set when astro telemetry is enabled")
}
}

func (s *ConfigSuite) TestBuildEnv_DoesNotSetAFConfigWhenAirflowDetected() {
cfg := &Config{AirflowURL: "http://localhost:14955"}
env := cfg.BuildEnv()
Expand Down