otto: forward astro telemetry-disabled state to Otto#2130
Open
jlaneve wants to merge 2 commits into
Open
Conversation
Users who run `astro telemetry disable` (or set ASTRO_TELEMETRY_DISABLED=1) expect that to cover anything launched via `astro otto` too. BuildEnv now checks internal/telemetry.IsEnabled() and sets OTTO_TELEMETRY_DISABLE=1 on the child when telemetry is off. Otto already has its own kill switch on that env var; this just plumbs astro-cli's existing setting through to it.
BuildEnv now calls telemetry.IsEnabled(), which reaches into config.CFG.TelemetryEnabled and panics if viper hasn't been initialized. TestConfigSuite was already calling testUtil.InitTestConfig — TestAfSuite wasn't, so TestBuildEnv_PrependsBinDirToPath nil-derefed in CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Coverage Report for CI Build 0Coverage increased (+0.002%) to 39.748%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
astro telemetry disableorASTRO_TELEMETRY_DISABLED=1), forward that to Otto by settingOTTO_TELEMETRY_DISABLE=1on the spawned processotto/ SDK invocations still need the env var explicitly, since they bypass astro-cliTest plan
go test ./pkg/otto/...passesastro telemetry disable && astro ottoand confirmOTTO_TELEMETRY_DISABLE=1reaches the child envastro telemetry enable && astro ottoand confirm the var is absent