Fix split_path_mapping behavior when mounting "/"

shin- · shin- · commit 60f7e021ada6 · 2016-06-13T15:32:10.000-07:00
Signed-off-by: Joffrey F &lt;joffrey@docker.com&gt;
diff --git a/compose/config/config.py b/compose/config/config.py
@@ -940,9 +940,10 @@ def split_path_mapping(volume_path):
     path. Using splitdrive so windows absolute paths won't cause issues with
     splitting on ':'.
     """
-    # splitdrive has limitations when it comes to relative paths, so when it's
-    # relative, handle special case to set the drive to ''
-    if volume_path.startswith('.') or volume_path.startswith('~'):
+    # splitdrive is very naive, so handle special cases where we can be sure
+    # the first character is not a drive.
+    if (volume_path.startswith('.') or volume_path.startswith('~') or
+            volume_path.startswith('/')):
         drive, volume_config = '', volume_path
     else:
         drive, volume_config = ntpath.splitdrive(volume_path)
diff --git a/tests/unit/config/config_test.py b/tests/unit/config/config_test.py
@@ -2682,6 +2682,13 @@ def test_split_path_mapping_with_windows_path_in_container(self):
         mapping = config.split_path_mapping('{0}:{1}'.format(host_path, container_path))
         assert mapping == expected_mapping
 
+    def test_split_path_mapping_with_root_mount(self):
+        host_path = '/'
+        container_path = '/var/hostroot'
+        expected_mapping = (container_path, host_path)
+        mapping = config.split_path_mapping('{0}:{1}'.format(host_path, container_path))
+        assert mapping == expected_mapping
+
 
 @pytest.mark.xfail(IS_WINDOWS_PLATFORM, reason='paths use slash')
 class BuildPathTest(unittest.TestCase):
