Skip to content

add logintime, wrapuptime, lastpause to QueueMemberRemovedEvent - #688

Merged
seanbright merged 5 commits into
asterisk-java:mainfrom
Gyomzz:687-unable-to-set-property-logintime-queue-member-removed-event
Feb 27, 2025
Merged

add logintime, wrapuptime, lastpause to QueueMemberRemovedEvent#688
seanbright merged 5 commits into
asterisk-java:mainfrom
Gyomzz:687-unable-to-set-property-logintime-queue-member-removed-event

Conversation

@Gyomzz

@Gyomzz Gyomzz commented Feb 14, 2025

Copy link
Copy Markdown

Fixes #687
Fixes #689
Fixes #690

@seanbright

Copy link
Copy Markdown
Member

Can you combine these 3 PRs into one?

@Gyomzz

Gyomzz commented Feb 25, 2025

Copy link
Copy Markdown
Author

Yeah sure

@Gyomzz
Gyomzz force-pushed the 687-unable-to-set-property-logintime-queue-member-removed-event branch from 65b171b to 77bb0fc Compare February 25, 2025 11:56
@Gyomzz Gyomzz changed the title add logintime to QueueMemberRemovedEvent add logintime, wrapuptime, lastpause to QueueMemberRemovedEvent Feb 25, 2025

@seanbright seanbright left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also make these same changes to QueueMemberAddedEvent? Then I think we're good to go.

Comment thread src/main/java/org/asteriskjava/manager/event/QueueMemberRemovedEvent.java Outdated
Comment thread src/main/java/org/asteriskjava/manager/event/QueueMemberRemovedEvent.java Outdated
Comment thread src/main/java/org/asteriskjava/manager/event/QueueMemberRemovedEvent.java Outdated
Comment thread src/main/java/org/asteriskjava/manager/event/QueueMemberRemovedEvent.java Outdated
Comment thread src/main/java/org/asteriskjava/manager/event/QueueMemberRemovedEvent.java Outdated
Comment thread src/main/java/org/asteriskjava/manager/event/QueueMemberRemovedEvent.java Outdated
@asterisk-java asterisk-java deleted a comment from Gyomzz Feb 26, 2025
@Gyomzz
Gyomzz requested a review from seanbright February 27, 2025 08:22
@seanbright
seanbright merged commit 3d32de0 into asterisk-java:main Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

2 participants