Skip to content

Base64.java: Deprecate our Base64 implementation in favor of Java's. #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbright merged 1 commit into from
Aug 27, 2024
+5 −3
Merged

Base64.java: Deprecate our Base64 implementation in favor of Java's. #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/org/asteriskjava/manager/event/SkypeChatMessageEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@
*/
package org.asteriskjava.manager.event;

import org.asteriskjava.util.Base64;

import java.nio.charset.StandardCharsets;
import java.util.Base64;

/**
* A SkypeChatMessageEvent is triggered when a Skype Chat message is sent or
Expand Down Expand Up @@ -107,6 +106,6 @@ public String getDecodedMessage() {
if (message == null) {
return null;
}
return new String(Base64.base64ToByteArray(message), StandardCharsets.UTF_8);
return new String(Base64.getDecoder().decode(message), StandardCharsets.UTF_8);
}
}
3 changes: 3 additions & 0 deletions src/main/java/org/asteriskjava/util/Base64.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@
* and vice-versa.<p>
* From java.util.prefs.
*
* @deprecated Use {@link java.util.Base64} instead.
*
* @author Josh Bloch
*/
@Deprecated
public class Base64 {

private Base64() {
Expand Down