Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 6 additions & 2 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
[*.{java,html}]
root = true

[*]
end_of_line = lf
insert_final_newline = true
charset = utf-8
indent_style = space
indent_size = 4
trim_trailing_whitespace = true

[*.{yml, yaml}]
[*.{yml,yaml}]
indent_size = 2
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
run: git diff

- name: Create Pull Request
uses: peter-evans/create-pull-request@v4.2.0
uses: peter-evans/create-pull-request@v4.2.2
with:
commit-message: Update versions to ${{ github.event.release.tag_name }}
title: Update versions to ${{ github.event.release.tag_name }}
Expand Down
Binary file removed .mvn/wrapper/maven-wrapper.jar
Binary file not shown.
18 changes: 0 additions & 18 deletions .mvn/wrapper/maven-wrapper.properties

This file was deleted.

File renamed without changes.
13 changes: 13 additions & 0 deletions asterisk-java-all/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
dependencies {
implementation project(':asterisk-java-ami')
implementation project(':asterisk-java-core')

implementation 'com.google.guava:guava:31.1-jre'
implementation 'org.slf4j:slf4j-api:2.0.4'
implementation 'org.apache.logging.log4j:log4j-core:2.19.0'
implementation 'org.reflections:reflections:0.10.2'

testImplementation 'ch.qos.logback:logback-classic:1.3.4'
}


Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Manifest-Version: 1.0
Class-Path:

Manifest-Version: 1.0
Class-Path:

Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@
* @version $Id$
* @since 0.2
*/
public class AsteriskVersion implements Comparable<AsteriskVersion>, Serializable
{
private static final String VERSION_PATTERN_18 = "^\\s*Asterisk (GIT-)?18[-. ].*";
private static final String VERSION_PATTERN_17 = "^\\s*Asterisk (GIT-)?17[-. ].*";
public class AsteriskVersion implements Comparable<AsteriskVersion>, Serializable {
private static final String VERSION_PATTERN_20 = "^\\s*Asterisk (GIT-)?20[-. ].*";
private static final String VERSION_PATTERN_19 = "^\\s*Asterisk (GIT-)?19[-. ].*";
private static final String VERSION_PATTERN_18 = "^\\s*Asterisk (GIT-)?18[-. ].*";
private static final String VERSION_PATTERN_17 = "^\\s*Asterisk (GIT-)?17[-. ].*";
private static final String VERSION_PATTERN_16 = "^\\s*Asterisk (GIT-)?16[-. ].*";
private static final String VERSION_PATTERN_15 = "^\\s*Asterisk (GIT-)?15[-. ].*";
private static final String VERSION_PATTERN_14 = "^\\s*Asterisk (GIT-)?14[-. ].*";
Expand Down Expand Up @@ -121,25 +122,40 @@ public class AsteriskVersion implements Comparable<AsteriskVersion>, Serializabl
*
* @since 2.1.0
*/
public static final AsteriskVersion ASTERISK_16 = new AsteriskVersion(1600, "Asterisk 16", VERSION_PATTERN_16,
VERSION_PATTERN_CERTIFIED_16);
public static final AsteriskVersion ASTERISK_16 = new AsteriskVersion(1600, "Asterisk 16", VERSION_PATTERN_16, VERSION_PATTERN_CERTIFIED_16);

/**
* Represents the Asterisk 17 series.
*
* @since 3.7.0
*/
public static final AsteriskVersion ASTERISK_17 = new AsteriskVersion(1700, "Asterisk 17", VERSION_PATTERN_17);
/**
* Represents the Asterisk 17 series.
*
* @since 3.7.0
*/
public static final AsteriskVersion ASTERISK_17 = new AsteriskVersion(1700, "Asterisk 17", VERSION_PATTERN_17);

/**
* Represents the Asterisk 18 series.
*
* @since 3.13.0
*/
public static final AsteriskVersion ASTERISK_18 = new AsteriskVersion(1800, "Asterisk 18", VERSION_PATTERN_18);

/**
* Represents the Asterisk 18 series.
*
* @since 3.13.0
*/
public static final AsteriskVersion ASTERISK_18 = new AsteriskVersion(1800, "Asterisk 18", VERSION_PATTERN_18);
/**
* Represents the Asterisk 19 series.
*
* @since 3.36.2
*/
public static final AsteriskVersion ASTERISK_19 = new AsteriskVersion(1900, "Asterisk 19", VERSION_PATTERN_19);

/**
* Represents the Asterisk 20 series.
*
* @since 3.36.2
*/
public static final AsteriskVersion ASTERISK_20 = new AsteriskVersion(2000, "Asterisk 20", VERSION_PATTERN_20);

private static final AsteriskVersion knownVersions[] = new AsteriskVersion[]{ASTERISK_18, ASTERISK_17, ASTERISK_16, ASTERISK_15, ASTERISK_14,
ASTERISK_13, ASTERISK_12, ASTERISK_11, ASTERISK_10, ASTERISK_1_8, ASTERISK_1_6};
private static final AsteriskVersion knownVersions[] = new AsteriskVersion[]{
ASTERISK_20, ASTERISK_19, ASTERISK_18, ASTERISK_17, ASTERISK_16, ASTERISK_15, ASTERISK_14, ASTERISK_13,
ASTERISK_12, ASTERISK_11, ASTERISK_10, ASTERISK_1_8, ASTERISK_1_6
};

// current debian stable version, as of 09/10/2018
public static final AsteriskVersion DEFAULT_VERSION = ASTERISK_16;
Expand All @@ -149,15 +165,13 @@ public class AsteriskVersion implements Comparable<AsteriskVersion>, Serializabl
*/
private static final long serialVersionUID = 1L;

private AsteriskVersion(int version, String versionString, String... patterns)
{
private AsteriskVersion(int version, String versionString, String... patterns) {
this.version = version;
this.versionString = versionString;

this.patterns = new Pattern[patterns.length];
int i = 0;
for (String pattern : patterns)
{
for (String pattern : patterns) {
this.patterns[i++] = Pattern.compile(pattern);
}
}
Expand All @@ -168,27 +182,22 @@ private AsteriskVersion(int version, String versionString, String... patterns)
*
* @param o the version to compare to
* @return <code>true</code> if this version is equal to or higher than the
* given version, <code>false</code> otherwise.
* given version, <code>false</code> otherwise.
*/
public boolean isAtLeast(AsteriskVersion o)
{
public boolean isAtLeast(AsteriskVersion o) {
return version >= o.version;
}

public int compareTo(AsteriskVersion o)
{
public int compareTo(AsteriskVersion o) {
return Integer.compare(version, o.version);
}

@Override
public boolean equals(Object o)
{
if (this == o)
{
public boolean equals(Object o) {
if (this == o) {
return true;
}
if (o == null || getClass() != o.getClass())
{
if (o == null || getClass() != o.getClass()) {
return false;
}

Expand All @@ -198,14 +207,12 @@ public boolean equals(Object o)
}

@Override
public int hashCode()
{
public int hashCode() {
return version;
}

@Override
public String toString()
{
public String toString() {
return versionString;
}

Expand All @@ -216,14 +223,10 @@ public String toString()
* @param coreLine
* @return the detected version, or null if unknown
*/
public static AsteriskVersion getDetermineVersionFromString(String coreLine)
{
for (AsteriskVersion version : knownVersions)
{
for (Pattern pattern : version.patterns)
{
if (pattern.matcher(coreLine).matches())
{
public static AsteriskVersion getDetermineVersionFromString(String coreLine) {
for (AsteriskVersion version : knownVersions) {
for (Pattern pattern : version.patterns) {
if (pattern.matcher(coreLine).matches()) {
return version;
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package org.asteriskjava;

import org.asteriskjava.fastagi.DefaultAgiServer;

import java.io.IOException;
import java.io.InputStream;
import java.util.Properties;

import org.asteriskjava.fastagi.DefaultAgiServer;

/**
* Simple command line interface for Asterisk-Java. This class is run when
* Asterisk-Java is started with {@code java -jar asterisk-java.jar}. It is
Expand Down Expand Up @@ -52,7 +52,7 @@ else if ("-a".equals(arg) || "-agi".equals(arg))
Integer port = null;
try
{
port = new Integer(args[1]);
port = Integer.valueOf(args[1]);
}
catch (NumberFormatException e)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,15 @@
*/
package org.asteriskjava.fastagi;

import org.asteriskjava.core.socket.SocketConnectionAdapter;
import org.asteriskjava.fastagi.internal.AgiConnectionHandler;
import org.asteriskjava.fastagi.internal.DefaultAgiChannelFactory;
import org.asteriskjava.fastagi.internal.FastAgiConnectionHandler;
import org.asteriskjava.util.*;
import org.asteriskjava.util.Log;
import org.asteriskjava.util.LogFactory;
import org.asteriskjava.util.ReflectionUtil;
import org.asteriskjava.util.ServerSocketFacade;
import org.asteriskjava.util.internal.ServerSocketFacadeImpl;
import org.asteriskjava.util.internal.SocketConnectionFacadeImpl;

import java.io.IOException;
import java.net.InetAddress;
Expand Down Expand Up @@ -67,7 +70,7 @@ public class DefaultAgiServer extends AbstractAgiServer implements AgiServer {
*
* @see Socket#setSoTimeout(int)
*/
private int socketReadTimeout = SocketConnectionFacadeImpl.MAX_SOCKET_READ_TIMEOUT_MILLIS;
private int socketReadTimeout = 10800000;

/**
* Creates a new DefaultAgiServer.
Expand Down Expand Up @@ -159,7 +162,7 @@ public DefaultAgiServer(String configResourceBundleName, MappingStrategy mapping
compositeMappingStrategy.addStrategy(new ClassNameMappingStrategy());
if (ReflectionUtil.isClassAvailable("javax.script.ScriptEngineManager")) {
MappingStrategy scriptEngineMappingStrategy = (MappingStrategy) ReflectionUtil
.newInstance("org.asteriskjava.fastagi.ScriptEngineMappingStrategy");
.newInstance("org.asteriskjava.fastagi.ScriptEngineMappingStrategy");
if (scriptEngineMappingStrategy != null) {
compositeMappingStrategy.addStrategy(scriptEngineMappingStrategy);
}
Expand Down Expand Up @@ -301,7 +304,7 @@ public void startup() throws IOException, IllegalStateException {
// loop will be terminated by accept() throwing an IOException when the
// ServerSocket is closed.
while (true) {
final SocketConnectionFacade socket;
final SocketConnectionAdapter socket;

// accept connection
try {
Expand All @@ -320,7 +323,7 @@ public void startup() throws IOException, IllegalStateException {

// execute connection handler
final AgiConnectionHandler connectionHandler = new FastAgiConnectionHandler(getMappingStrategy(), socket,
this.getAgiChannelFactory());
this.getAgiChannelFactory());
try {
execute(connectionHandler);
} catch (RejectedExecutionException e) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
package org.asteriskjava.fastagi.internal;

import org.asteriskjava.ami.action.response.ManagerResponse;
import org.asteriskjava.fastagi.AgiException;
import org.asteriskjava.fastagi.AgiWriter;
import org.asteriskjava.fastagi.command.AgiCommand;
import org.asteriskjava.manager.ManagerConnection;
import org.asteriskjava.manager.TimeoutException;
import org.asteriskjava.manager.action.AgiAction;
import org.asteriskjava.manager.response.ManagerError;
import org.asteriskjava.manager.response.ManagerResponse;

import java.io.IOException;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,11 @@
*/
package org.asteriskjava.fastagi.internal;

import org.asteriskjava.core.socket.SocketConnectionAdapter;
import org.asteriskjava.fastagi.AgiChannelFactory;
import org.asteriskjava.fastagi.AgiReader;
import org.asteriskjava.fastagi.AgiWriter;
import org.asteriskjava.fastagi.MappingStrategy;
import org.asteriskjava.util.SocketConnectionFacade;

import java.io.IOException;

/**
* An AgiConnectionHandler for FastAGI.
Expand All @@ -37,7 +35,7 @@ public class FastAgiConnectionHandler extends AgiConnectionHandler {
/**
* The socket connection.
*/
private final SocketConnectionFacade socket;
private final SocketConnectionAdapter socket;

/**
* Creates a new FastAGIConnectionHandler to handle the given FastAGI socket connection.
Expand All @@ -46,7 +44,7 @@ public class FastAgiConnectionHandler extends AgiConnectionHandler {
* @param socket the socket connection to handle.
* @param agiChannelFactory The factory to use for creating new AgiChannel instances.
*/
public FastAgiConnectionHandler(MappingStrategy mappingStrategy, SocketConnectionFacade socket, AgiChannelFactory agiChannelFactory) {
public FastAgiConnectionHandler(MappingStrategy mappingStrategy, SocketConnectionAdapter socket, AgiChannelFactory agiChannelFactory) {
super(mappingStrategy, agiChannelFactory);
this.socket = socket;
}
Expand All @@ -65,7 +63,7 @@ protected AgiWriter createWriter() {
public void release() {
try {
socket.close();
} catch (IOException e) // NOPMD
} catch (Exception e) // NOPMD
{
// swallow
}
Expand Down
Loading