Replaced slow Scanner by LineReader (own implementation) #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we did a test with heavy load (and tons of events), it turned out that the
Scannerused inSocketConnectionFacadeImplis slow and burns CPU.I first removed the
Scannerand used the underlayingBufferedReader, but this broke the detection of line endings.So I ended up with replacing the combination of
BufferedReaderandScannerby an own implementation calledLineReader. It behaves like aBufferedReaderexcept for a custom pattern for line endings.BTW: for the implementation, I also had to migrate the patterns from regex to string
I did some benchmarks of how long it takes to slice 1GB of text into lines (see
LineReaderTest):13140ms BufferedReader+Scanner
1768ms LineReader
1678ms BufferedReader