Skip to content

Fix #124. Improve error reporting when non-iterable data provided. #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astanin merged 1 commit into from
Sep 26, 2024
Merged

Fix #124. Improve error reporting when non-iterable data provided. #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions tabulate/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,15 +1357,24 @@ def _normalize_tabular_data(tabular_data, headers, showindex="default"):
is_headers2bool_broken = True # noqa
headers = list(headers)

err_msg = (
"\n\nTo build a table python-tabulate requires two-dimensional data "
"like a list of lists or similar."
"\nDid you forget a pair of extra [] or ',' in ()?"
)
index = None
if hasattr(tabular_data, "keys") and hasattr(tabular_data, "values"):
# dict-like and pandas.DataFrame?
if hasattr(tabular_data.values, "__call__"):
# likely a conventional dict
keys = tabular_data.keys()
rows = list(
izip_longest(*tabular_data.values())
) # columns have to be transposed
try:
rows = list(
izip_longest(*tabular_data.values())
) # columns have to be transposed
except TypeError: # not iterable
raise TypeError(err_msg)

elif hasattr(tabular_data, "index"):
# values is a property, has .index => it's likely a pandas.DataFrame (pandas 0.11.0)
keys = list(tabular_data)
Expand All @@ -1388,7 +1397,10 @@ def _normalize_tabular_data(tabular_data, headers, showindex="default"):
headers = list(map(str, keys)) # headers should be strings

else: # it's a usual iterable of iterables, or a NumPy array, or an iterable of dataclasses
rows = list(tabular_data)
try:
rows = list(tabular_data)
except TypeError: # not iterable
raise TypeError(err_msg)

if headers == "keys" and not rows:
# an empty table (issue #81)
Expand Down