Repository navigation
Improve support for ANSI escape sequences and document the behavior - #184
Merged
Merged
Conversation
Contributor
|
That's great indeed! Would love to have this merged upstream! |
Contributor
|
I implemented a while ago a regex to strip ANSI sequences like you did here. Just a note if you want to compare implementations: https://github.com/mahmoud/boltons/blob/6c7fa3e05659fac6515f661153c89d4ad02df168/boltons/strutils.py#L374-L428 |
kdeldycke
added a commit
to kdeldycke/meta-package-manager
that referenced
this pull request
Jul 8, 2022
Owner
|
Thank you. This seems to be a much cleaner implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I kept having issues when piping the output of a command whose output was colorized with ANSI escape sequences. The length calculations for strings that contained non-printable ANSI were incorrect and resulted in columns being misaligned. I modified the regex for this to handle CSI escaped codes and OSC escaped hyperlinks (for terminals that support it).
I've also some documentation to explain the technical details as well as explain the output behavior when ANSI sequences are present.
I think this should also resolve #164 and #150