Skip to content
This repository was archived by the owner on Dec 29, 2021. It is now read-only.

Add Assert::ignore_status() for ignoring the command status#56

Merged
epage merged 2 commits intoassert-rs:masterfrom
dsprenkels:ignore_status
Oct 17, 2017
Merged

Add Assert::ignore_status() for ignoring the command status#56
epage merged 2 commits intoassert-rs:masterfrom
dsprenkels:ignore_status

Conversation

@dsprenkels
Copy link

@dsprenkels dsprenkels commented Oct 17, 2017 •
edited
Loading

Implements Assert::ignore_status(), which can be used to ignore whether a command exited successfully.

Fixes #23.

@dsprenkels dsprenkels changed the title Add Assert::ignore_status for ignoring the command status Add Assert::ignore_status() for ignoring the command status Oct 17, 2017
@killercup killercup requested a review from epage October 17, 2017 11:19
@killercup
Copy link
Collaborator

killercup commented Oct 17, 2017

Thanks! Don't worry about the CI error, it's a known issue (see #50 (comment)).

r? @epage

Do we want the docs to mention that this will reset previously set assertions?

@epage
Copy link
Collaborator

epage commented Oct 17, 2017

Do we want the docs to mention that this will reset previously set assertions?

Might be nice because this doesn't just turn off the implicit succeeds() but also turns off the explicit .fails_with(code).

@dsprenkels
Copy link
Author

dsprenkels commented Oct 17, 2017

I updated the PR with the new docstring.

Daan Sprenkels added 2 commits October 17, 2017 17:35
Implement Assert::ignore_status
4de8e96 
Fixes #23
Add note to ignore_status about existing asserts
95be0f1 
Namely, it removes any assertions that were previously made.
@epage
Copy link
Collaborator

epage commented Oct 17, 2017

bors: r+

bors bot added a commit that referenced this pull request Oct 17, 2017
@bors
Merge #56
7a7fbb5 
56: Add Assert::ignore_status() for ignoring the command status r=epage a=dsprenkels

Implements `Assert::ignore_status()`, which can be used to ignore whether a command exited successfully.

Fixes #23.
@bors
Copy link
Contributor

bors bot commented Oct 17, 2017

Build failed

@epage
Copy link
Collaborator

epage commented Oct 17, 2017

Oh, right. Since nothing is lost with merging it anyways, I guess I'll do it manually.

@epage epage merged commit a01f933 into assert-rs:master Oct 17, 2017
@dsprenkels dsprenkels deleted the ignore_status branch October 17, 2017 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@epage epage Awaiting requested review from epage

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsprenkels @killercup @epage