You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 8, 2020. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts all dependency versions into one file that his shared will all projects. This makes it easier to ensure versions are consistent.
@SteveSandersonMS I made this a separate PR from #721 as the change is not essential to the VS 2017 upgrade. We are moving towards this model in our other aspnet repos.
@natemcmaster,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request. Thanks,
.NET Foundation Pull Request Bot
Thanks @natemcmaster! This is a big improvement and is now merged.
I did edit the commit a little when merging. I reverted the changes to the templates projects .csproj files (e.g, Angular2Spa, ReactSpa, etc.). That's because those aren't just regular .NET projects - they are the input to the system that builds Yeoman and dotnet new templates. As given, the tokenised values (e.g., $(AspNetCoreVersion) would have ended up in the template packages, which then would have generated projects that can't compile (because the dependencies.props file wouldn't be there). Also there's an argument that the dependency versions we use in the templates don't need to be the same as we use elsewhere, and we need to make separate decisions about when to change those dependency versions. So overall I think it's preferable to continue specifying those versions explicitly and independently. Hope that's OK!
Ah, thanks for clarifying. I wasn't 100% sure that the template projects were for. Thanks for cleaning it up 👍
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts all dependency versions into one file that his shared will all projects. This makes it easier to ensure versions are consistent.
@SteveSandersonMS I made this a separate PR from #721 as the change is not essential to the VS 2017 upgrade. We are moving towards this model in our other aspnet repos.