api changes

ran404 · ran404 · commit b7051b10fde2 · 2018-08-28T12:48:52.000+01:00
diff --git a/simpleplotly/figure.py b/simpleplotly/figure.py
@@ -35,7 +35,7 @@ def update_layout(self, **kwargs):
 
     def drop_layout_key(self, key):
         if key in self.figure.layout:
-            del self.figure.layout[key]
+            setattr(self.figure.layout, key, None)
         return self
 
     def to_image(self, filename, format=None, width=None, height=None, scale=None):
diff --git a/tests/test_figure.py b/tests/test_figure.py
@@ -8,11 +8,19 @@
 class FigureHolderTest(unittest.TestCase):
     def test_can_update_layout(self):
         fh = sp.FigureHolder(go.Figure())
+        layout = fh.figure.layout
+
+        self.assertIsNone(layout.barmode)
+        self.assertIsNone(layout.title)
+
         fh.update_layout(barmode='group', title='test plot')
-        self.assertDictEqual(fh.figure.layout, dict(barmode='group', title='test plot'))
+        # self.assertDictEqual(fh.figure.layout._props, dict(barmode='group', title='test plot'))
+        self.assertEqual(layout.barmode, 'group')
+        self.assertEqual(layout.title, 'test plot')
 
         fh.drop_layout_key('barmode')
-        self.assertDictEqual(fh.figure.layout, dict(title='test plot'))
+        self.assertIsNone(layout.barmode)
+        self.assertEqual(layout.title, 'test plot')
 
 
 class FigureBuilderTest(unittest.TestCase):
