Change lhs/inout parameter of assign functions to mutable ref#224
Merged
9prady9 merged 2 commits intoarrayfire:masterfrom May 28, 2020
Merged
Change lhs/inout parameter of assign functions to mutable ref#2249prady9 merged 2 commits intoarrayfire:masterfrom
9prady9 merged 2 commits intoarrayfire:masterfrom
Conversation
This is required since by default a varialble reference immutable in rust. However, arrayfire C API for assignment operations, af_assign_seq and af_assign_gen, does use lhs as output. Thus, an Array passed as lhs might get modifed some times, thus breaking the immutable ref rule. This change fixes that by converting the lhs/inout paramters of assignment functions to mutable references and removes return values completely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required since by default a varialble reference immutable in
rust. However, arrayfire C API for assignment operations, af_assign_seq
and af_assign_gen, does use lhs as output. Thus, an Array passed as
lhs might get modifed some times, thus breaking the immutable ref rule.
This change fixes that by converting the lhs/inout paramters of
assignment functions to mutable references and removes return values
completely.
Fixes #222