Implement (Scalar +-*/ Array)#207
Closed
ctrl-z-9000-times wants to merge 2 commits intoarrayfire:masterfrom
ctrl-z-9000-times:master
Closed
Implement (Scalar +-*/ Array)#207ctrl-z-9000-times wants to merge 2 commits intoarrayfire:masterfrom ctrl-z-9000-times:master
ctrl-z-9000-times wants to merge 2 commits intoarrayfire:masterfrom
ctrl-z-9000-times:master
Conversation
Member
|
Thank you! I don't test full breath of ArrayFire functionality in this wrapper since upstream takes care of it. But I do want to eventually test wrapper calls; Having said that, current tests are doc tests that are written as example codes in each function's documentation - so if you add some example code on how to use the new feature you added. That will check the wrapper call - which should be sufficient for now. Can you please remove the merge commit. You can avoid such issues if a new feature/bug branch is created on your fork based on upstream's(repo on arrayfire account not your fork) master instead of using your fork's master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @9prady9,
I implemented the overloaded operators as you suggested. I don't know what your testing standards are, so I've only done a minimal amount of testing by hand.
Also, it turns out that the function which I previously tried to add (
scalar) is already implemented as theconvertfunction, so I could have made the equation1 / Arraywork with1.convert() / ArrayI hope this helps!