Skip to content

fix(oneapi): account for indexed subarray offset #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Open

fix(oneapi): account for indexed subarray offset #3737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/backend/oneapi/kernel/index.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ class indexKernel {
trimIndex(s3 ? gw * p.steps[3] + p.offs[3] : ptr3[gw],
inp.dims[3]);
// offset input and output pointers
const T* src = (const T*)in.get_pointer() + (i + j + k + l);
const T* src =
(const T*)in.get_pointer() + inp.offset + (i + j + k + l);
T* dst = (T*)out.get_pointer() +
(gx * outp.strides[0] + gy * outp.strides[1] +
gz * outp.strides[2] + gw * outp.strides[3]);
Expand Down
13 changes: 13 additions & 0 deletions test/index.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1622,6 +1622,19 @@ TEST(Indexing, SNIPPET_indexing_ref) {
// TODO: Confirm the outputs are correct. see #697
}

TEST(Indexing, IndexArrayOnSubarrayUsesSubarrayOffset) {
array data = iota(dim4(100)).as(s32);
array slice = data(seq(10, 29));

const uint h_indices[] = {0, 1, 2, 3};
array indices(4, h_indices);
array result = slice(indices);

int actual[4] = {};
result.host(actual);
for (int i = 0; i < 4; ++i) { ASSERT_EQ(10 + i, actual[i]); }
}

TEST(Indexing, IndexingCopy) {
array A = constant(0, 1, s32);
af::index s1;
Expand Down