api: materialise a strided view before assigning into it - #3729
Draft
melonakos wants to merge 1 commit into
Draft
Conversation
An array that is itself a non-linear view (a = a.rows(0, 3)) lost every element assignment: createSubArray copies a non-linear parent before slicing it, so the write landed in a temporary. The assignment path now copies such an output to a linear array first. Fixes #3534.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning an element into an array that is itself a non-linear view silently did nothing on every backend: after
a = a.rows(0, 3),a(0, 0) = 1234leaves a unchanged (#3534). The sequence-assignment path slices the output with createSubArray, which copies a non-linear parent before slicing it, so the write landed in a temporary. When the output is not linear it is now copied to a linear array first, the same thing that already happens when the output is shared. Adds a regression test covering sequence and index-array assignment into a view.Verified on the CPU backend and on OpenCL (Intel Arc B580 and UHD 770): the new test fails on master and passes with the fix, and the assign suite passes in full on all three.