build: add AF_WITH_GRAPHICS to build without Forge, OpenGL and glad - #3724
Draft
melonakos wants to merge 1 commit into
Draft
build: add AF_WITH_GRAPHICS to build without Forge, OpenGL and glad#3724melonakos wants to merge 1 commit into
melonakos wants to merge 1 commit into
Conversation
Users embedding ArrayFire as a compute library have had to patch out the graphics stack by hand because Forge headers, glad and OpenGL were fetched and compiled unconditionally. AF_WITH_GRAPHICS (default ON) keeps today's behaviour; OFF skips those dependencies and the graphics sources in every backend, and compiles stubs for the thirty public graphics functions that return AF_ERR_NOT_CONFIGURED, the same way image IO behaves without FreeImage. The graphics examples are skipped and AF_BUILD_FORGE is ignored when it is OFF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
AF_WITH_GRAPHICS(default ON) so ArrayFire can be built as a pure compute library. Users embedding it have been patching out the graphics stack by hand because Forge headers, glad and OpenGL were fetched and compiled unconditionally (this came up again from Pix4D, and #2878 has been open for years).With the option OFF the build skips OpenGL, glad and the Forge dependency, drops the graphics sources from every backend, and compiles stubs for the thirty public graphics functions that return
AF_ERR_NOT_CONFIGURED, the same way image IO behaves without FreeImage; the exported symbol set is unchanged, so the unified backend and existing binaries keep working.AF_BUILD_FORGEbecomes dependent on it and the graphics examples are skipped.Verified on Windows: CPU, OpenCL and CUDA 13 backends build with the option OFF and ON, the unified library and the CPU examples build with it OFF, a check program gets 302 from
af_create_windowandaf_showthrough bothafcpuand the unifiedafwhile the rest of the API works, and the sparse/backend/info suites pass. The full oneAPI library builds with the option OFF and ON (icx 2026.0). A no-graphics leg is added to the Linux CPU CI matrix.