Skip to content

unified: do not call a null symbol in af_get_last_error #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
melonakos wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −0
Draft

unified: do not call a null symbol in af_get_last_error #3718

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cda1c99
Guard against unresolved symbol in unified af_get_last_error
melonakos Aug 29, 2026
312bc21
unified: return an empty string, not NULL, when no backend is loaded
melonakos Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/api/unified/error.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,22 @@ void af_get_last_error(char **str, dim_t *len) {
void *vfn = LOAD_SYMBOL();
af_func func = nullptr;
memcpy(&func, &vfn, sizeof(void *));

// LOAD_SYMBOL() returns null when no backend library is loaded or
// the symbol cannot be resolved. Unlike CALL(), this function
// returns void and cannot report AF_ERR_LOAD_LIB, so hand back an
// empty message the way the C API does, rather than calling
// through a null pointer. Callers pass the string straight to
// printf-style formatting, so it must not be NULL.
if (func == nullptr) {
void *empty = nullptr;
af_alloc_host(&empty, sizeof(char));
memcpy(str, &empty, sizeof(void *));
(*str)[0] = '\0';
if (len) { *len = 0; }
return;
}

func(str, len);
}
}
Expand Down
Loading