Conversation
LOAD_SYMBOL() returns null when no backend library is loaded or the symbol cannot be resolved. af_get_last_error called the resulting function pointer unconditionally, which is an indirect call through a null pointer. Every other unified entry point goes through CALL(), which null-checks and returns AF_ERR_LOAD_LIB. af_get_last_error returns void and cannot, so report an empty error instead. Fixes #3713 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012SRueobKykUocB1SRdHsEE
melonakos
force-pushed
the
fix/3713-unified-null-symbol
branch
from
September 10, 2026 18:47
701862a to
44d14aa
Compare
Every caller passes len as NULL and formats the message with %s, so a NULL string is undefined behaviour. Allocate an empty message the way the C API does.
melonakos
force-pushed
the
fix/3713-unified-null-symbol
branch
from
September 10, 2026 18:47
44d14aa to
312bc21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no backend is loaded, LOAD_SYMBOL() returns null and af_get_last_error called through it. The function returns void so it cannot report AF_ERR_LOAD_LIB; return an empty error instead. Fixes #3713.