Skip to content

Fixed topk for half, marked sort_index with half unsupported #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edwinsolisf merged 1 commit into from
Jul 15, 2025
Merged

Fixed topk for half, marked sort_index with half unsupported #3680

edwinsolisf merged 1 commit into from
Jul 15, 2025

Conversation

@edwinsolisf
Copy link
Contributor

@edwinsolisf edwinsolisf commented Jul 14, 2025

Fix for topk with half input. Added unsupported error when calling sort_index with half

Description

  • Is this a new feature or a bug fix? Bug fix
  • Potential impact on specific hardware, software or backends: OpenCL backend
  • New functions and their functionality: support for topk half
  • Can this PR be backported to older versions?
  • Future changes not implemented in this PR.

Fixes: #3675

Changes to Users

  • Additional options added to the build: None
  • What changes will existing users have to make to their code or build steps? None

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@edwinsolisf edwinsolisf merged commit a699cb9 into arrayfire:master Jul 15, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syurkevi syurkevi syurkevi approved these changes

Assignees

No one assigned

Labels

OpenCL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] sort_by_key with fp16 values result is incorrect

2 participants

@edwinsolisf @syurkevi