Skip to content

Conversation

@willyborn
Copy link
Contributor

Adds support for sub-arrays for transform and transform_coordinates

Description

10cceac: Increased difficulty of sub-array testing
The sub-arrays are now extended, so that wrong usage will generate full random arrays, or out of buffer writes.

7eb18e9: Fixes sub-array (cpu, cuda, oneapi, opencl) for transform
- Adds offset processing for the opencl/oneapi kernels (ft array)
- In all backends the provided ft array is verified for Linearity, and if not copied.
- Tests are extended for transform and transform_coordinates

Additional information about the PR answering following questions:

  • Is this a new feature or a bug fix?
    • Bug.
  • Why these changes are necessary.
    • Without this fix, arrayfire will give a response although based on random values. No error will be generated, so it will be unnoticed by most.
  • Potential impact on specific hardware, software or backends.
    • None
  • New functions and their functionality.
    • None
  • Can this PR be backported to older versions?
    • No
  • Future changes not implemented in this PR.
    • None

Changes to Users

Correct response will be provided in case of sub-arrays used in ft parameter.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@christophe-murphy christophe-murphy merged commit e58f6df into arrayfire:master Jul 8, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants