Fix half precision pow function for oneAPI back end #3672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An incorrect power function was being used for half precision variables when building the JIT kernel for the oneAPI back end which lead to a fallback to an integer power function causing the result to be rounded. This fixes that.
edwinsolisf
previously approved these changes
Jun 27, 2025
Contributor
edwinsolisf
left a comment
edwinsolisf
left a comment
There was a problem hiding this comment.
The same must be done on the OpenCL Backend
…as well." This reverts commit e335721.
Contributor
Author
|
@edwinsolisf Could you re-approve. Didn't see that you had already put in a PR for the OpenCL version #3676. Thanks |
edwinsolisf
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An incorrect power function was being used for half precision variables when building the JIT kernel for the oneAPI back end which lead to a fallback to an integer power function causing the result to be rounded. This fixes that.
Checklist