Skip to content

Conversation

@willyborn
Copy link
Contributor

When 2 arrays have a common base (JIT), the order of the join was not respected. This fix is already applied to opencl, cuda an cpu before although not yet for oneapi.

Description

28bd60b0: adds the the function toTempFormat to the test helpers. This function generates the different temporary array formats (JIT array, SUB-array, Linear array, ...) used by arrayfire.
811669f: The JIT kernel generation is adapted so that the order of the parameters is respected in the write out of the results.

  • Is this a new feature or a bug fix?
    BUG
  • Why these changes are necessary.
    BEFORE RANDOM RESULTS ARE GENERATED, BECAUSE THE RESULTS were written in the wrong arrays (depending on internal presentation)
  • Potential impact on specific hardware, software or backends.
    ONEAPI, BECAUSE ALREADY FIXED IN THE OTHER BACKENDS
  • New functions and their functionality.
    NONE
  • Can this PR be backported to older versions?
    DIFFICULT
  • Future changes not implemented in this PR.
    NONE

Fixes: #3511 #3513

Changes to Users

BUG FIX, difficult to detect.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@syurkevi syurkevi requested a review from umar456 June 20, 2025 19:14
@christophe-murphy christophe-murphy merged commit 700db10 into arrayfire:master Jun 25, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] found on AF 3.8.3 and 3.9.0 for OPENCL, possibly with af::join

3 participants