Windows installer fixes #3655
Merged
Windows installer fixes #3655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with find AF_MKL.
…ed for building on Linux
syurkevi
previously approved these changes
Jun 3, 2025
syurkevi
approved these changes
Jun 3, 2025
willyborn
pushed a commit
to willyborn/arrayfire
that referenced
this pull request
Jun 4, 2025
* Additional libraries for standalone installer and fix ilp consistency with find AF_MKL. * Yet More oneAPI libraries and name typo fixes * Remove libraries already provided by runtime * Move additional mkl libraries collection into block for non-static build. * Fixes to enable SYCL language to work with MSVC runtime library variables * Fixes to find FreeImage for Windows build * Fixes to allow Nvidia libraries to be found for Windows build * Fixes to allow all oneAPI and MKL libraries to be found for Windows build * Fixes for CPack scripts to work with NSIS installer on Windows * Fixes to find tbb libraries. * Add missing Debug/Release flags for SYCL compiler on Windows * Add boost program-options dependency required for clFFT * fix typos in CMakeSYCLInformation * Add Windows defines * Only attempt to include debug data files in the installer package for debug builds. * Revert some changes that removed some library installs which are needed for building on Linux * Install Visual C++ redistributable as part of the Windows installer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes required for the code to build on Windows and find all the required libraries to be installed when making the NSIS installer package for Windows. This requires PR #3646 and PR #3651