Add minimum driver version check to allow minor version compatibility. #3648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syurkevi
previously approved these changes
Mar 28, 2025
umar456
approved these changes
Apr 4, 2025
willyborn
pushed a commit
to willyborn/arrayfire
that referenced
this pull request
Jun 4, 2025
arrayfire#3648) * Add minimum driver version check to allow minor version compatibility. * Simpler method of checking for nvidia driver cuda minor version compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the only check performed was to compare the runtime version that the code was compiled with to the cuda version corresponding to the driver. This means that there was no minor version compatibility check. The error message given was also incorrect since it printed out the minimum driver required for minor version compatibility.
Changes to Users
The actual driver version is now also checked against the minimum required version to allow minor version compatibility.
Checklist