Use offsets for CSR/COO to dense conversion in OpenCL and oneAPI #3633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rting from sparse CSR/COO to dense for the OpenCL and oneAPI back ends. Test has been updated to also confirm fix for COO sparse format.
Contributor
Author
|
This depends on oneAPI fixes so will wait till they are merged. |
Contributor
Author
|
Ready to merge now |
…a more descriptive name.
umar456
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offset values for sparse arrays are now taken into account when converting from sparse CSR/COO to dense for the OpenCL and oneAPI back ends. Test has been updated to also confirm fix for COO sparse format.
Fixes: #1918
Checklist