Fix for incorrect x axis values for histogram. #3590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lied to x axis min and max values but this should not be done for a histogram where the values are in fact bin labels.
2 tasks
edwinsolisf
approved these changes
Dec 30, 2024
Contributor
edwinsolisf
left a comment
edwinsolisf
left a comment
There was a problem hiding this comment.
Tested on windows, works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rounding was being applied to x axis min and max values but this should not be done for a histogram where the values are in fact bin labels.
xmin and xmax are now always equal to the first and last bin respectively.
Checklist