Skip to content

Conversation

@christophe-murphy
Copy link
Contributor

Fixes for bugs uncovered by CUDA version 12.6

Description

  • Merge in fixes from 3575 bug shfl down sync bug causes undefined behavior #3576 for shuffle sync bugs
  • Fixed bugs in calls to ormqr routine in the qr and leastSquares where the correct workspace size was not being calculated
  • Loosened tolerance on the convolution filter tests for the floating point type from 2.0e-3 to 4.0e-3. The convolution routines appear to be working correctly but produce slightly different results than older CUDA versions. Not sure why.
  • All CUDA tests pass now for CUDA version 12.6

Fixes: #3580

Checklist

  • [x ] Rebased on latest master
  • [x ] Code compiles
  • [x ] Tests pass
  • [x ] Functions added to unified API
  • [x ] Functions documented

…rp primitives and calls the new primitives for CUDA versions greater than 9 and the old ones for older CUDA versions. The new primitives have an additional argument which is a mask of the warp threads that are participating in the operation. The old primitives always involve all the threads in a warp. The wrapper routines originally allowed you to specify the mask which was ignored for the old primitives but this has now been removed. This is because if an old version of CUDA is being used then all threads must enter the wrapper routine and if a new version of CUDA is being used only the threads corresponding to the mask must enter. If threads outside the mask enter the routine then the behavior is undefined. In CUDA versions <=12.2 the primitive executes without any errors given however in later versions of CUDA a warp illegal instruction exception will be thrown. In order to preserve the same behavior of these wrapper functions for old and new versions of CUDA, the mask is always set to all threads in a warp for the new primitives. The specific new primitive can always be called with a custom mask which is already done elsewhere in the reduce_by_key routine.
… cusolver ormqr routine call which was causing memory errors.
…workspace size was not being calculated for the cusolver ormqr routine.
Copy link
Contributor

@FloopCZ FloopCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for digging into this!

@FloopCZ
Copy link
Contributor

FloopCZ commented Dec 7, 2024

This patch is now a part of the ArrayFire Arch Linux repository package.

Copy link
Contributor

@edwinsolisf edwinsolisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows 11, passed all tests

christophe-murphy and others added 2 commits January 7, 2025 16:40
Update driver versions to minimum required.

Co-authored-by: Filip Matzner <FloopCZ@users.noreply.github.com>
@edwinsolisf edwinsolisf self-requested a review January 9, 2025 00:38
@christophe-murphy christophe-murphy merged commit f4edcf2 into master Jan 9, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Investigate test failures when running with CUDA 12.6

4 participants