Skip to content

Added testing for sequence indexing with non-unitary steps #3587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christophe-murphy merged 1 commit into from
Feb 11, 2025
Merged

Added testing for sequence indexing with non-unitary steps #3587

christophe-murphy merged 1 commit into from
Feb 11, 2025

Conversation

@edwinsolisf
Copy link
Contributor

@edwinsolisf edwinsolisf commented Aug 20, 2024 •
edited
Loading

When sequences are mixed in array indexing, af::backend::index is called. This pull request adds a test for this function call for the case where the sequences have a step that is not 1.

Description

Additional information about the PR answering following questions:

  • Is this a new feature or a bug fix?: Adds a test
  • Why these changes are necessary: Tests uncovered case
  • Potential impact on specific hardware, software or backends: None
  • New functions and their functionality: None
  • Can this PR be backported to older versions?: Yes
  • Future changes not implemented in this PR.: None

Tests pull request #3585

Changes to Users

  • Additional options added to the build: None
  • No action required by the user

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@melonakos melonakos added this to the 3.10 milestone Feb 5, 2025
@christophe-murphy
Copy link
Contributor

christophe-murphy commented Feb 10, 2025

New test data in arrayfire/arrayfire-data#21 will be merged with this test.

@christophe-murphy christophe-murphy self-requested a review February 10, 2025 17:28
@christophe-murphy christophe-murphy merged commit c644e4f into arrayfire:master Feb 11, 2025
christophe-murphy added a commit that referenced this pull request Feb 15, 2025
@christophe-murphy
The test cmake file needs to be updated with the commit hash which in…
713cc1d 
…cludes the new test data needed for the test added in pull requests #3585 and #3587.
@christophe-murphy christophe-murphy mentioned this pull request Feb 15, 2025
Merged
3 tasks
christophe-murphy added a commit that referenced this pull request Feb 20, 2025
@christophe-murphy
The test cmake file needs to be updated with the commit hash which in…
ccabfe6 
…cludes the new test data needed for the test added in pull requests #3585 and #3587. (#3635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophe-murphy christophe-murphy christophe-murphy approved these changes

Assignees

No one assigned

Labels

test

Projects

None yet

Milestone

3.10

Development

Successfully merging this pull request may close these issues.

3 participants

@edwinsolisf @christophe-murphy @melonakos