Skip to content

Workaround fix for issue with inline namespace thrust #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christophe-murphy merged 3 commits into from
Nov 5, 2024
Merged

Workaround fix for issue with inline namespace thrust #3566

christophe-murphy merged 3 commits into from
Nov 5, 2024

Conversation

@edwinsolisf
Copy link
Contributor

@edwinsolisf edwinsolisf commented Jun 12, 2024

Temporary fix for inline namespace with thrust compiling with MSVC

Description

  • Is this a new feature or a bug fix?: Temporary fix
  • More detail if necessary to describe all commits in pull request.
  • Why these changes are necessary: workaround for compiler bug affecting template specialization with inline namespace used in ThrustArrayFirePolicy.hpp
  • Potential impact on specific hardware, software or backends: CUDA backend on Windows
  • New functions and their functionality.: None
  • Can this PR be backported to older versions?: NA
  • Future changes not implemented in this PR: None
    Fixes: [Build] MSVC Compiler Bug affecting thrust library in CUDA Backend #3565

Changes to Users

  • No additional options added to the build.
  • No action required by the user

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@christophe-murphy christophe-murphy self-requested a review October 17, 2024 13:14
@christophe-murphy
Copy link
Contributor

christophe-murphy commented Oct 17, 2024 •
edited
Loading

Hi Edwin, thanks for finding this! I was trying to compile with Windows and wondering what was going on!

I just have a couple of comments, I think things might have got messed up by clang format. Thanks

@christophe-murphy christophe-murphy mentioned this pull request Oct 18, 2024
Open
2 tasks
@brfire
Copy link

brfire commented Oct 28, 2024

Would be good to land this, I got stuck on it for a couple hours.

@christophe-murphy
Update ThrustArrayFirePolicy.hpp
e24499f 
Hi Edwin, there seems to be an issue caused by the clang format apply. I propose these changes.
@christophe-murphy
Copy link
Contributor

christophe-murphy commented Oct 30, 2024

I made some changes. Compiling works on my Windows runner, see here: https://github.com/christophe-murphy/arrayfire/actions/runs/11387289958/job/31681529494

If you are happy with it, then I'll merge it.

@edwinsolisf
Copy link
Contributor Author

edwinsolisf commented Nov 2, 2024

Looks good to me! Go ahead and merge it

christophe-murphy
christophe-murphy approved these changes Nov 5, 2024
View reviewed changes
@christophe-murphy christophe-murphy merged commit 5c18fb3 into arrayfire:master Nov 5, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophe-murphy christophe-murphy christophe-murphy approved these changes

Assignees

No one assigned

Labels

build fix Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Build] MSVC Compiler Bug affecting thrust library in CUDA Backend

3 participants

@edwinsolisf @christophe-murphy @brfire