3560 bug incorrect results when using the pow function with float16 arguments with cuda backend#3561
Merged
christophe-murphy merged 4 commits intomasterfrom Jan 30, 2025
Conversation
…uments with the CUDA backend. Since the half precision CUDA library doesn't have a pow function, the default pow function is used, casting the arguments to double precision.
edwinsolisf
previously approved these changes
Jan 16, 2025
Contributor
edwinsolisf
left a comment
edwinsolisf
left a comment
There was a problem hiding this comment.
Works, tested on windows with an RTX3070 Ti Mobile
…pow-function-with-float16-arguments-with-cuda-backend
edwinsolisf
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When AF_WITH_FAST_MATH is disabled, the pow function definition incorrectly casts float16 arguments to integers.
Description
This error occurs when AF_WITH_FAST_MATH is disabled however when it is enabled the arguments are cast to double precision. This has been changed to always cast to double precision.
Fixes: #3560
Checklist