3545 bug fp16 types not allowed for atan2 method #3559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwinsolisf
approved these changes
Jan 7, 2025
Contributor
edwinsolisf
left a comment
edwinsolisf
left a comment
There was a problem hiding this comment.
Works, tested on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to use atan2 and hypot functions with fp16 arguments.
Description
Cases have been added to the atan2 and hypot functions to handle fp16 arguments. Previously an exception was thrown when trying to use fp16 arguments with these functions.
Tests have been added to verify that these functions are working correctly with fp16 arguments. Note that the OpenCL back end does not support half precision.
Several other functions have been identified as not supporting fp16, a new issue will be created for these.
Fixes: #3545
Changes to Users
atan2 and hypot functions can now be used on fp16 arrays
Checklist