add int8 matmul support to CUDA backend #3508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwinsolisf
previously approved these changes
Mar 16, 2025
Contributor
edwinsolisf
left a comment
edwinsolisf
left a comment
There was a problem hiding this comment.
Tested on RTX 3070Ti all backends on Ubuntu & Windows
changes to gemm account for differing input/output types
Contributor
Author
|
Squashed commits and rebased on master. Included a minor lint fix to whitespace that I apparently missed. My apologies if this interfered with your process! |
edwinsolisf
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for int8 matmul in the CUDA backend using cublasGemmEx functions. This modifies the gemm functions' api to support a different output array type, so all backends were modified.
This PR depends on s8 support: #3507
Fixes: #1656
Checklist