fix fallthrough in reduce_by_key_common for u8#3503
Merged
christophe-murphy merged 1 commit intoarrayfire:masterfrom Feb 17, 2025
Merged
fix fallthrough in reduce_by_key_common for u8#3503christophe-murphy merged 1 commit intoarrayfire:masterfrom
christophe-murphy merged 1 commit intoarrayfire:masterfrom
Conversation
This fixes minByKey/maxByKey for u8.
christophe-murphy
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix for reduce_by_key_common where u8 would run reduce_key for u8, and then f16 but with the u8 arrays.
Affects af::minByKey and af::maxByKey, which would throw/segfault for u8 depending on backend.
The ReduceByKey tests related to this bug were updated so that they run for each supported type.
Checklist