Skip to content

Add support for CUDA 12 #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
umar456 merged 18 commits into from
Jan 10, 2023
Merged

Add support for CUDA 12 #3352

umar456 merged 18 commits into from
Jan 10, 2023

Conversation

@umar456
Copy link
Member

@umar456 umar456 commented Jan 1, 2023 •
edited
Loading

Changes to support CUDA 12

Description

  • Remove deprecated cuSPARSE API
  • Move all internal namespaces in the arrayfire namespace
  • Add Version class to support multiple versions of loaded libraries
  • Add support for sparse arrays in ASSERT_ARRAYS_* test macros

Fixes #3353 #3354

Changes to Users

  • Compile ArrayFire with CUDA 12
  • Currently CUDA 10 support is removed because of C++17 changes.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@umar456
Put all internal symbols in the arrayfire namespace
3e5c870 
There were some conflicts in the new cuda and oneapi version. This needed to be
done because the namespaces we used can conflict with other libraries.
@umar456
Move oneapi namespace into the arrayfire namespace
7ebb03c
@umar456
Fix af_spdlog target for non-header-only builds
53cf9a6
@umar456
Make CUDA libraries for dynamic linking private
c611a2b
@umar456 umar456 force-pushed the cuda12 branch 7 times, most recently from dfa6059 to 5661ffa Compare January 3, 2023 01:40
@umar456 umar456 force-pushed the cuda12 branch 3 times, most recently from 863e70f to 489ae22 Compare January 3, 2023 13:23
syurkevi
syurkevi reviewed Jan 3, 2023
View reviewed changes
syurkevi
syurkevi reviewed Jan 3, 2023
View reviewed changes
syurkevi
syurkevi previously approved these changes Jan 3, 2023
View reviewed changes
@umar456 umar456 force-pushed the cuda12 branch 4 times, most recently from 187ad17 to 20dc583 Compare January 9, 2023 23:00
@umar456 umar456 merged commit b6f234e into arrayfire:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syurkevi syurkevi syurkevi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] CU_CHECK does not check for validity of CUDA messages extracted from error code

2 participants

@umar456 @syurkevi