Static MKL build fixes #3244
Merged
Static MKL build fixes #3244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need to call the mkl_set_threading_layer and mkl_set_interface_layer functions for shared library builds of MKL. Static builds do not need those functions.
The unified backend was linking to the OpenCL library. This was done to include the header but the library was also linking. Fixed this issue by using the INTERFACE_INCLUDE_DIRECTORIES generator expression to include the OpenCL header
syurkevi
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build when AF_WITH_STATIC_MKL is set to ON.
Description
to setup the libmkl_rt libray. These functions are not required for static versions of the
library.
Fixes: Static linking afcpu with MKL does nt work anymore with the 3.8 branch #3242
Changes to Users
N/A
Checklist
[ ] Functions added to unified API[ ] Functions documented