Fix nested and duplicate moddims jit issue with the CPU backend #3232
+130
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umar456
force-pushed
the
moddim_jit_fix
branch
2 times, most recently
from
3b102c6 to
1068fee
Compare
syurkevi
previously approved these changes
Mar 21, 2022
Fix an issue that caused errors with nested moddims caused errors with the CPU backend. this was caused when the moddims function was called back to back on the same array. Another issue that this fixes is when you have the same node which are composed of moddims arrays in the same jit tree
syurkevi
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with nested and duplicate moddims JIT nodes with the CPU backend
Description
Fix an issue that caused errors with nested moddims caused errors with the CPU
backend. this was caused when the moddims function was called back to back on
the same array.
Another issue that this fixes is when you have the same node which are composed
of moddims arrays in the same jit tree
Changes to Users
N/A
Checklist
[ ] Functions added to unified API[ ] Functions documented