handles empty arrays in join_many #3211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syurkevi
force-pushed
the
join_many_empty
branch
from
83cd954 to
a70d8d1
Compare
syurkevi
force-pushed
the
join_many_empty
branch
from
a70d8d1 to
f1d4319
Compare
umar456
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
af_join_many() would throw an exception when passed empty arrays. This was inconsistent with af_join().
With this PR, af_join_many() will ignore empty arrays.
bug fix
Now that empty arrays are allowed, the first non-empty array must be used for assertions.
Internal API has slightly changed to accept pre-allocated array. More functions will be moving to this style.
internal API of af_join() doesn't yet match af_join_many(&out)
Fixes: #3209
Changes to Users
No changes to existing code should be necessary, but join() with multiple arrays will now handle empty arrays.
Checklist