Allow moddims operations to be part of the JIT tree if possible #3177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
requested changes
Oct 11, 2021
2 tasks
9prady9
approved these changes
Oct 13, 2021
9prady9
pushed a commit
to 9prady9/arrayfire
that referenced
this pull request
Oct 13, 2021
…yfire#3177) * Implement JIT moddims for CUDA and OpenCL * Create a moddims node instead of modifying setDataDims * Cleanup headers after moddims change * Address feedback (cherry picked from commit a800d9f)
syurkevi
pushed a commit
that referenced
this pull request
Dec 28, 2021
* Implement JIT moddims for CUDA and OpenCL * Create a moddims node instead of modifying setDataDims * Cleanup headers after moddims change * Address feedback (cherry picked from commit a800d9f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the moddims function so that it can be included into the JIT tree if the array object is linear. This change makes it possible to perform automatic broadcasting in a future change.
Description
Changes to Users
Users shouldn't need to make changes to code to take advantage of this change.
Checklist
[ ] Functions added to unified API