fix transform operator for countByKey #3175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umar456
approved these changes
Sep 30, 2021
9prady9
pushed a commit
to 9prady9/arrayfire
that referenced
this pull request
Oct 5, 2021
* fix transform operator for countByKey (cherry picked from commit 2444ef5)
syurkevi
added a commit
that referenced
this pull request
Dec 28, 2021
* fix transform operator for countByKey (cherry picked from commit 2444ef5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #3062 where countByKey would give incorrect results for any n > 128 (block size). When there is more than one block's worth of reduction, multiple reduction iterations occur.
The af_nonzero_t transformation would reset the reduced values back to a non-zero flag (1) instead of the actual count between reduction iterations. This operator is now replaced with the af_add_t operator in consequent iterations.