Update CUDA driver version checks #3161
Merged
+119
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
requested changes
Jul 27, 2021
Member
9prady9
left a comment
9prady9
left a comment
There was a problem hiding this comment.
Let's keep the driver version commit specific that itself. Please move the cleanup changes in that commit to the other commit which already has lot of cleanup and code movement.
Otherwise, looks good.
I am looking into the vcpkg failure, it is not related to this change.
src/backend/cuda/device_manager.cpp
Outdated
| {7000, 346.46f, 347.62f}}; | ||
| // clang-format on | ||
|
|
||
| static inline int getMinSupportedCompute(int cudaMajorVer) { |
Member
There was a problem hiding this comment.
Please move this function movement changes into cleanup commit.
| } | ||
|
|
||
| // pulled from CUTIL from CUDA SDK | ||
| static inline int compute2cores(unsigned major, unsigned minor) { |
Member
There was a problem hiding this comment.
Please move this function movement changes into cleanup commit.
9prady9
previously approved these changes
Jul 27, 2021
umar456
force-pushed
the
update_cuda
branch
2 times, most recently
from
5d1de60 to
faf7432
Compare
9prady9
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CUDA driver version information for CUDA 11.4
Description
Changes to Users
None
Checklist
[ ] Functions added to unified API[ ] Functions documented