Use normalized rng data for Large* tests of pinverse #3152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Float type has accuracy issues with large input values for pinverse computations. This change updates the data sets for Large & LargeTall tests that has this accuracy issue.
9prady9
force-pushed
the
pinverse_test_fix
branch
from
737568d to
01f9e4b
Compare
syurkevi
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Float type has accuracy issues with large input values which is the case with current test data for Large & LargeTall test inputs.
Changes to Users
None
Checklist
[ ] Functions added to unified API[ ] Functions documented