Skip to content

Free unlocked buffers before tests run in rng quality tests #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9prady9 merged 2 commits into from
Jun 22, 2021
Merged

Free unlocked buffers before tests run in rng quality tests #3151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0999d6a
Free unlocked buffers before tests run in rng quality tests
9prady9 Jun 22, 2021
a6c26a1
Fix formatting
9prady9 Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/rng_quality.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using af::allTrue;
using af::array;
using af::constant;
using af::deviceGC;
using af::dtype;
using af::dtype_traits;
using af::randomEngine;
Expand All @@ -16,7 +17,10 @@ using af::sum;
template<typename T>
class RandomEngine : public ::testing::Test {
public:
virtual void SetUp() {}
virtual void SetUp() {
// Ensure all unlocked buffers are freed
deviceGC();
Copy link
Contributor

@willyborn willyborn Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to unlock all buffers, you need to add af::sync() before the deviceGC().
Without the sync, the buffers which are still in use by executing kernels will not be freed.

Copy link
Member Author

@9prady9 9prady9 Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not the case with deviceGC in this location. When test finishes, all arrays involved are already evaluated because they need to be brought to host for comparison. So, they will be marked as unused by the time this line hits before the next test starts.

Copy link
Member

@umar456 umar456 Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally all allocation and free function are device synchronization events.

}
};

// create a list of types to be tested
Expand Down