Add missing batch support check in sparse-dense arith ops #3129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umar456
approved these changes
May 5, 2021
syurkevi
pushed a commit
that referenced
this pull request
Dec 28, 2021
* Add missing batch support check in sparse-dense arith ops * Fix formatting (cherry picked from commit ecce064)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #1988
Changes to Users
Prior to this change, sparse-dense arithmetic API calls incorrectly continued with the operation where batch support was in fact not yet available. Until such support is added later, we need correctly return an appropriate error code.
Checklist
[ ] Functions added to unified API[ ] Functions documented