Fix glad add_subdirectory to fix out of tree builds#3106
Merged
9prady9 merged 1 commit intoarrayfire:masterfrom Mar 10, 2021
Merged
Fix glad add_subdirectory to fix out of tree builds#31069prady9 merged 1 commit intoarrayfire:masterfrom
9prady9 merged 1 commit intoarrayfire:masterfrom
Conversation
This was a problem on the arrayfire-benchmark repo where the repository is built as a subproject
syurkevi
approved these changes
Mar 10, 2021
9prady9
approved these changes
Mar 10, 2021
Member
9prady9
left a comment
9prady9
left a comment
There was a problem hiding this comment.
Won't change anything. I must have excluded the explicit binary directory since the glad target is an interface and doesn't get built directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a problem on the arrayfire-benchmark repo where the repository
is built as a subproject
Description
Add the binary directory to the add_subdirectory command that adds the glad repository.
This was causing errors with the arrayfire-benchmark repository when building master.
Changes to Users
N/A
Checklist
[ ] Functions added to unified API[ ] Functions documented