Remove non-free guards for SIFT/GLOH algorithms #3071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
force-pushed
the
free_sift
branch
3 times, most recently
from
6d853b5 to
6d73f23
Compare
3 tasks
umar456
previously approved these changes
Jan 11, 2021
9prady9
force-pushed
the
free_sift
branch
3 times, most recently
from
a0b2d39 to
6bb51f2
Compare
SIFT patent expired recently and these algorithms can be provided as part of open source binaries that are distributed from our website.
9prady9
force-pushed
the
free_sift
branch
4 times, most recently
from
cd1d4dd to
7985cb0
Compare
syurkevi
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SIFT patent expired recently and these algorithms can be provided as part of open source binaries that are distributed from our
website.
Fixes: #3007
Changes to Users
None to existing users. New users will be able to use sift/gloh functions from the installations done using our website binaries.
Checklist
[ ] Tests pass[ ] Functions added to unified API[ ] Functions documented